Update navigation logic #247
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes any concepts that assume a device may only have a single active session at a time. This allows multiple non-exclusive VRSessions to be active at once, which will be important for enabling various interesting magic window scenarios in the future. With this change starting an exclusive session suspends the non-exclusive ones, but doesn’t end them. IDL Changes: - Remove VRDevice.activeSession - VRDevice.onsessionchange -> VRSession.onended
Wanted to explicitly state the differences between the two modes and why you’d want to use one or the other.
toji
added a commit
that referenced
this pull request
Jul 11, 2017
Also merged in some navigation concepts from #247
toji
added a commit
that referenced
this pull request
Jul 11, 2017
Also merged in some navigation concepts from #247
toji
added a commit
that referenced
this pull request
Jul 22, 2017
Also merged in some navigation concepts from #247
toji
added a commit
that referenced
this pull request
Sep 21, 2017
Also merged in some navigation concepts from #247
toji
added a commit
that referenced
this pull request
Nov 1, 2017
Also merged in some navigation concepts from #247
toji
added a commit
that referenced
this pull request
Nov 1, 2017
Refactored to use VRSessionRequestController pattern, which should be more compatible with other cancelable promises in the future. Also merged in some navigation concepts from #247
toji
added a commit
that referenced
this pull request
Nov 1, 2017
Refactored to use VRSessionRequestController pattern, which should be more compatible with other cancelable promises in the future. Also merged in some navigation concepts from #247
toji
added a commit
that referenced
this pull request
Nov 1, 2017
Refactored to use VRSessionRequestController pattern, which should be more compatible with other cancelable promises in the future. Also merged in some navigation concepts from #247
toji
added a commit
that referenced
this pull request
Feb 20, 2018
Refactored to use VRSessionRequestController pattern, which should be more compatible with other cancelable promises in the future. Also merged in some navigation concepts from #247
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prompted by @kearwood’s comments on #236. Would love your feedback on this! I seriously doubt that I've covered everything that I need to.
Changed navigation detection mechanism from an event to a promise, since that frees us from worrying that pages may miss the event if they register for it too late. Does require some language about not allowing the transition after a certain period of time. Probably need more guarantees to be made there. Also, not sure if I'm a fan of the name
getNavigationDeviceOne last note: The previous text indicated that we should provide a session but I don't know if that will really work given the type of feature detection and configuration we're talking about attaching to session creation time like output canvases.